parca-dev
Associate correct compiler metadata for the containerized apps
Sometimes we associate the 'not so accurate' compiler metadata for the containerized applications, especially when no information regarding the compiler is available. Below is the output of jps showing the java applications running on the system.
vaishali@pop-os:~$ sudo jps
298407 spring-two-0.0.2-SNAPSHOT.jar
298719 Jps
246237 spring-0.0.1-SNAPSHOT.jar
Screenshots of what parca-agent shows for both applications:
-
For the process running on the host
-
For the application running in a docker container(check cgroup_name)
In the case of Java, it'll be fixed with the ongoing work as part of #1306. But this might be happening for other processes. Opening this so that I don't forget to check and fix it later.
Discussed this with @brancz . One idea is to not call the label compiler to avoid confusion for users as this can also be the case for the applications that are statically linking the runtimes of other languages.
In the case of Java, we'll go for having a separate label that says Java=yes.
I would suggest using java=true, but I think that's a formality (it's just what's widely used in the Prometheus ecosystem and we want things to feel as familiar as possible). Overall agreed. 💯
