parca-agent icon indicating copy to clipboard operation
parca-agent copied to clipboard

Replace `unix.ByteSliceFromString` with own implementation

Open brancz opened this issue 3 years ago • 4 comments

unix.ByteSliceFromString is behind a build tag, which causes it not to work under windows. I stumbled over this while trying to add windows as a build target in parca-debuginfo. As far as I can tell we should easily be able to replace this with our own implementation, which would allow us to support windows in parca-debuginfo.

brancz avatar Nov 15 '22 15:11 brancz

In the end, this was extracted to another project and I think it will be unlikely for the Agent to ever support windows. Should we close this issue or is it still something we want to work on?

javierhonduco avatar Nov 29 '23 17:11 javierhonduco

This is not about the agent supporting windows, just some packages, so that dependents of those can at least compile on windows (obviously nothing ebpf related).

brancz avatar Nov 29 '23 17:11 brancz

That was my understanding, but should we close the issue or do you think that we still want to reuse this code?

javierhonduco avatar Nov 29 '23 19:11 javierhonduco

We still active are using it in the parca-debuginfo component.

brancz avatar Nov 29 '23 20:11 brancz