instiki icon indicating copy to clipboard operation
instiki copied to clipboard

textile autolinks do not work anymore

Open villem opened this issue 15 years ago • 5 comments

This probably maraoku related regression. With older releases the http://url and [email protected] were automatically made proper html tags.

We have wiki starting from 0.7 releases so we cannot easily switch to different markup language.

villem avatar Sep 04 '09 08:09 villem

Autolinking was disabled in Revision 166 because the autolinking code sucked.

Anyone who wants to try fixing the code, so that it isn't as ridiculously slow, and is guaranteed not to produce ill-formed XHTML output, is welcome to do so. If they succeed, I'll re-enable auto-linking.

distler avatar Sep 04 '09 14:09 distler

Ok. Thanks for this pointer. We might enable this in our wiki. We do not use any advanced new features that has come since 0.7.

villem avatar Sep 14 '09 06:09 villem

You can close this one. It seems that comment and close is not working for me.

villem avatar Sep 14 '09 06:09 villem

Only Matthias or I can close issues.

As you have discovered, it's easy-enough to re-enable Autolinking-support. If this really does not cause any problems in the Textile formatter (it definitely causes problems with the Markdown formatter, and with the "advanced" new features), we might consider re-enabling it for Textile only.

Therefore, I think I will keep this issue open, as a reminder.

distler avatar Sep 14 '09 18:09 distler

I tried to re-enable the autolink code e.g just revert the commit http://github.com/parasew/instiki/commit/3a3cfeaa9b43a15e7cfbb90113465ab6f258e968. But this did not enable autolinking. Maybe I need to revert more?

villem avatar Sep 15 '09 11:09 villem