encore icon indicating copy to clipboard operation
encore copied to clipboard

Ability to compile pony runtime with gcc 7.x

Open Thizizmyname opened this issue 6 years ago • 6 comments

Make sure these boxes are checked before submitting your pull request:

  • [✓] Description of the pull request stating the problem and the solution
  • [ x ] Tests (if applicable)
  • [ x ] Documentation (if applicable)

This is a solution to #863 The ponyrt needs to be compiled with the flag -latomic as well as every encore project needs to be linked with said flag.

NOTE: This should be tested on multiple devices before acceptance

Thizizmyname avatar May 25 '18 13:05 Thizizmyname

tests compile and pass on: Ubuntu 17.10 gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0 clang version 4.0.1-6 (tags/RELEASE_401/final)

Thizizmyname avatar May 25 '18 13:05 Thizizmyname

I can confirm that this works. Can someone check backwards compatibility on a old GCC?

Alternative option: only support clang. Thoughts?

TobiasWrigstad avatar Jun 11 '18 22:06 TobiasWrigstad

~Can confirm that this compiles on my machine~ (running clang 700.1.81 on MacOSX 10.10.5). I don't have GCC installed.

EDIT: I cannot actually compile Encore programs in this build:

ld: library not found for -latomic

Alternative option: only support clang. Thoughts?

I'm fine with only supporting clang. Would we be excluding any platforms doing that?

EliasC avatar Jul 10 '18 07:07 EliasC

only support clang. Thoughts?

#864

Would we be excluding any platforms doing that?

It's OK to assume none until the real need appears.

albertnetymk avatar Jul 16 '18 19:07 albertnetymk

Given the lack of man power to work on Encore right now, this seems reasonable to me.

16 juli 2018 kl. 21:59 skrev Albert Netymk <[email protected]mailto:[email protected]>:

only support clang. Thoughts?

#864https://github.com/parapluu/encore/pull/864

Would we be excluding any platforms doing that?

It's OK to assume none until the real need appears.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/parapluu/encore/pull/865#issuecomment-405363027, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAWRWNxL47h-gD22AwWWhx5UM6en2s8Fks5uHPCagaJpZM4UOAGr.

När du har kontakt med oss på Uppsala universitet med e-post så innebär det att vi behandlar dina personuppgifter. För att läsa mer om hur vi gör det kan du läsa här: http://www.uu.se/om-uu/dataskydd-personuppgifter/

E-mailing Uppsala University means that we will process your personal data. For more information on how this is performed, please read here: http://www.uu.se/om-uu/dataskydd-personuppgifter/

TobiasWrigstad avatar Jul 16 '18 22:07 TobiasWrigstad

Given the merge of #864, clean clone should work on linux with clang installed. Could someone else with a linux box confirm it?

albertnetymk avatar Jun 12 '19 20:06 albertnetymk