StepViewAndroid icon indicating copy to clipboard operation
StepViewAndroid copied to clipboard

Draws Labels inside the circles

Open jibbo opened this issue 6 years ago • 2 comments

This PR enables to write the labels inside the circles instead of below. This is especially useful when a user needs to draw different numbers, such as the example below:

Before: Screenshot 2019-11-12 at 11 19 57

After: Screenshot 2019-11-12 at 11 13 54

Note that this can be used to write inside the circles labels like "A", "B" or "C", thus giving a bit more flexibility to the library.

Let me know if you don't like something and I'll fix it or if something isn't clear.

Thanks a lot.

jibbo avatar Nov 12 '19 10:11 jibbo

Thank you for your contribution. I will check and update you on the PR by the end of the week.

On Tue, Nov 12, 2019 at 11:22 PM Giovanni De Francesco < [email protected]> wrote:

This PR enables to write the labels inside the circles instead of below. This is especially useful when a user needs to draw different numbers, such as the example below:

Before: [image: Screenshot 2019-11-12 at 11 19 57] https://user-images.githubusercontent.com/2427135/68663095-6216e400-053e-11ea-8ed1-e7a44401945c.png

After: [image: Screenshot 2019-11-12 at 11 13 54] https://user-images.githubusercontent.com/2427135/68662946-17956780-053e-11ea-9e91-d3c3cc14c6a4.png

Note that this can be used to write inside the circles labels like "A", "B" or "C", thus giving a bit more flexibility to the library.

Let me know if you don't like something and I'll fix it or if something isn't clear.

Thanks a lot.

You can view, comment on, or merge this pull request online at:

https://github.com/params-ing/StepViewAndroid/pull/8 Commit Summary

  • made possible to have labels only inside
  • clean up

File Changes

Patch Links:

  • https://github.com/params-ing/StepViewAndroid/pull/8.patch
  • https://github.com/params-ing/StepViewAndroid/pull/8.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/params-ing/StepViewAndroid/pull/8?email_source=notifications&email_token=AG4QI4H5IOBM7W5PMIBYPATQTJ7XVA5CNFSM4JMBLCB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYU2RZQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4QI4HX5DXPWOVXIHEZLH3QTJ7XVANCNFSM4JMBLCBQ .

params-ing avatar Nov 12 '19 10:11 params-ing

Thanks for the review, I'll try to do make these changes next weekend.

jibbo avatar Nov 18 '19 11:11 jibbo