parallel icon indicating copy to clipboard operation
parallel copied to clipboard

Fix: check bonus config in crowdloan

Open mclyk opened this issue 2 years ago • 2 comments

Add more checks when updateBonusconfig.

mclyk avatar Oct 28 '22 03:10 mclyk

@GopherJ pls check this PR, and do you think if we need to ensure start_time>current_time when updating bonus config? like mentioned in this card: https://parallelfi.atlassian.net/browse/BTE-962

mclyk avatar Oct 28 '22 03:10 mclyk

Codecov Report

Base: 58.42% // Head: 58.48% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (86bbb13) compared to base (cf61201). Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
+ Coverage   58.42%   58.48%   +0.05%     
==========================================
  Files         194      194              
  Lines       19740    19768      +28     
==========================================
+ Hits        11533    11561      +28     
  Misses       8207     8207              
Impacted Files Coverage Δ
pallets/crowdloans/src/benchmarking.rs 0.00% <ø> (ø)
pallets/streaming/src/lib.rs 83.59% <80.00%> (ø)
pallets/crowdloans/src/lib.rs 68.11% <100.00%> (+0.15%) :arrow_up:
pallets/crowdloans/src/tests.rs 100.00% <100.00%> (ø)
pallets/crowdloans/src/types.rs 83.33% <100.00%> (+3.33%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 28 '22 06:10 codecov-commenter