parallel icon indicating copy to clipboard operation
parallel copied to clipboard

Asset manager release checklist

Open 0x8f701 opened this issue 3 years ago • 3 comments

  • [x] Make name consistent, we are using AssetRegistrar as trait name, will be good to use asset-registrar for pallet name to make it consistent
  • [x] mv hard coded pallet id to runtime as a pallet config
  • [x] mv AssetRegistrar trait to primitives/src/xcm.rs
  • [x] rename primitives/src/xcm_gadget.rs to primitives/src/xcm.rs
  • [ ] simplify migration code to insert only units per second & asset id <-> multilocation mapping
  • [x] register_asset make metadata mandatory
  • [ ] version management of multilocation passed in parameters

0x8f701 avatar Apr 11 '22 13:04 0x8f701

About the migration the new pallet should work side by side with the legacy foreign assets, so I would suggest we keep this pr focused and move that to future pr.

yrong avatar Apr 13 '22 07:04 yrong

Remove AssetRegistrar trait since we manually created new asset so do not need

yrong avatar Apr 13 '22 07:04 yrong

Since without the VersionedMultilocation we can still fulfill the future migration, and the register call is usually not used directly by frontend, so we keep it simple here just use Multilocation

yrong avatar Apr 13 '22 07:04 yrong