rust-tss-esapi icon indicating copy to clipboard operation
rust-tss-esapi copied to clipboard

Published 20 hours ago • verified publisher icon parallaxsecond

20240728 vendored tss

Open Firstyear opened this issue 1 year ago • 10 comments

This builds on #523 to improve the README as well as improving the autoconf handling for bundled tpm2-tss.

Firstyear avatar Jul 28 '24 05:07 Firstyear

Could you pull out the serde fixes out of this PR. They would be easier to get reviewed and approved.

Superhepper avatar Aug 05 '24 07:08 Superhepper

@Superhepper https://github.com/parallaxsecond/rust-tss-esapi/pull/538 pulled them out here.

Firstyear avatar Aug 06 '24 02:08 Firstyear

I have tried to run this locally on my Windows 11 machine with Visual Studio 2022 and I cannot get cargo build --features="bundled generate-bindings" to work.

It crashes on line 44 in the msbuild crate where it tries to run unwrap on a None value.

Superhepper avatar Nov 11 '24 20:11 Superhepper

I have tried to run this locally on my Windows 11 machine with Visual Studio 2022 and I cannot get cargo build --features="bundled generate-bindings" to work.

It crashes on line 44 in the msbuild crate where it tries to run unwrap on a None value.

@Firstyear @uglyoldbob I got this to build now after some hacking. Would any of you mind if I closed this PR and open a new one where I continue this work?

Superhepper avatar Nov 13 '24 20:11 Superhepper

Of course, go for it!

Firstyear avatar Nov 13 '24 23:11 Firstyear

It would be really helpful if it would be possible to make updates to the msbuild crate.

Superhepper avatar Jan 19 '25 14:01 Superhepper

@Superhepper Do you have a pull request for the msbuild crate?

uglyoldbob avatar Jan 20 '25 13:01 uglyoldbob

@uglyoldbob I tried to find the repo that was hosting the crate in order to see if I could make a pull request. But I was unable to find it.

Superhepper avatar Jan 20 '25 13:01 Superhepper

@superhepper Oh I must have forgot to set that property. It is at https://github.com/uglyoldbob/msbuild

uglyoldbob avatar Jan 20 '25 13:01 uglyoldbob

@uglyoldbob I made a PR not sure if you saw it.

Superhepper avatar Jan 28 '25 14:01 Superhepper

@uglyoldbob Would be possible to make a new release of the msbuild crate?

Superhepper avatar Aug 27 '25 20:08 Superhepper

So my PR is now in draft state for everyone to look at so I am going to close this one.

Superhepper avatar Aug 28 '25 20:08 Superhepper