parallaxsecond
Fix the link checker job
The existing link checker didn't really work (it threw errors but they were not reported). Replace with something that actually works :sweat_smile:
Check if all check succeededeven though one of them didn't... why? 😢
The check-matrix has dependency only on check matrix, but not on the tests-softhsmandtest-kryoptic` (nor on any other that we might want to depend on):
https://github.com/parallaxsecond/rust-cryptoki/actions/runs/16598679948/workflow?pr=302#L82
If we want this test to depend on any other intpus, they needs to be specified in needs dict.
Thanks for the explanation! I think that by now these two are pretty stable... So... I propose we make them required too. Objections? CC @hug-dev
Fine with me.
Note, that its nicely visualized in the pipeline summary with the dependency connection:
https://github.com/parallaxsecond/rust-cryptoki/actions/runs/16598679948?pr=302
I would not mind adding the other checks (spell, formatting, clippy, ...) as dependencies as we also want them to succeed. I do not remember what was required before though, but the point of changing from depending on several jobs was to have this configurable from within the git repo instead from the git webui (and avoid the need to require dozens of jobs to pass).
I would not mind adding the other checks (spell, formatting, clippy, ...) as dependencies as we also want them to succeed. I do not remember what was required before though, but the point of changing from depending on several jobs was to have this configurable from within the git repo instead from the git webui (and avoid the need to require dozens of jobs to pass).
Yes I like this reason! We can add them all there so that no admin is need on the UI :) The original reason was also to simplify admin and not manually add the matrix variants to the UI
