parallaxinc
Multiple Violations on console
Recent console capture shows violations. Disregard websocket errors, just look for "[violation]" below.
blocklyprop.com-1558709527392.log
Any thoughts on what rule is being violated? These all look like timing concerns, so this might be more of a code tuning opportunity rather than an error.
The times for setInterval and setTimeout are not crazy, but maybe they are a violation in the context for which they are used which is probably slowing the UI down.
What looks to me to be the problem is the ace editor (non-passive event listener to a scroll-blockling 'mousewheel' event). Maybe there's a ace editor update that already fixes this. The other messages may or may not be related.
Each of these violations may be a new warning feature of Chrome 73 or 74.
The code packages (ace, bootstrap and jquery) are grossly overdue for updates. We're at least 2 years behind on these. However, they each contain breaking changes in the upgrade path. We must implement these thoughtfully. But soon.
Upgrading Ace does not appear to break anything...you can try plunking it in to see if it's been addressed in the newer version.
On Fri, May 24, 2019 at 10:15 AM Jim Ewald [email protected] wrote:
The code packages (ace, bootstrap and jquery) are grossly overdue for updates. We're at least 2 years behind on these. However, they each contain breaking changes in the upgrade path. We must implement these thoughtfully. But soon.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/parallaxinc/BlocklyProp/issues/1677?email_source=notifications&email_token=AEWSVOGYH6C2IZSGLKCCCFDPXAPBPA5CNFSM4HPRC64KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGAJXY#issuecomment-495715551, or mute the thread https://github.com/notifications/unsubscribe-auth/AEWSVOA7KSHRMQKJ7KJLFCLPXAPBPANCNFSM4HPRC64A .
Removing the "bug" label and replacing it with "task" - no functionality is broken currently - and many of these are simply out of our control as they are buried inside of the blocklyprop's dependencies.
@PropGit @zfi can one of you create a /parallaxinc/ fork of the following so we can start the process of testing to see what it will take to upgrade our dependencies?
jQuery Ace Editor Bootstrap Datatables - not a current dependency, but we'll be switching to this soon
Will do, but let's set this task aside until week of 6/3 when @zfi and I are both back and able to follow along and help.