jsPDF icon indicating copy to clipboard operation
jsPDF copied to clipboard

Context2D does not implement rect() correctly

Open andrewcmyers opened this issue 3 years ago • 5 comments

It should add a closed subpath with four segments. Instead, it adds an open subpath with six segments.

andrewcmyers avatar Apr 09 '22 20:04 andrewcmyers

Thanks for the report. Could you prepare a PR?

HackbrettXXX avatar Apr 14 '22 10:04 HackbrettXXX

Previous experience with doing a PR for #3273 has not been fruitful.

andrewcmyers avatar Apr 14 '22 11:04 andrewcmyers

would like to grab. please can you tell me exactly what needs to be done ?

Mayank1728 avatar Apr 01 '23 11:04 Mayank1728

There already two PRs to fix this. I think the test cases just need to be updated on one of them.

andrewcmyers avatar Apr 01 '23 18:04 andrewcmyers

I think my fix is more correct fwiw.

andrewcmyers avatar Apr 01 '23 18:04 andrewcmyers