jsPDF
jsPDF copied to clipboard
Links breaks when use addPage with another size
Hi!
I'm facing an issue, links breaks when .addPage() with another format than the initial size, apparently the position of the link became incorrect.
Reproduce:
- Start new doc with an specific size
- Put some link anywhere in the first page
- addPage() with an different size
- The link inserted in the first page doesn't respect anymore the position passed.
Notice that this occurs with textWithLink and also link(). If the addPage() has the same size of initial format links work's just fine. I made an fiddle to help:
Works: https://jsfiddle.net/MarceloZapatta/don4hqtj/
Breaks: https://jsfiddle.net/fL403sja/2/
Yes, that's a bug. The links are written when the pages are finalized. Here the getHorizontal/VerticalCoordinateString
functions are no longer valid (they use the dimensions of the last active page). The final bounds need to be stored when the link
function is executed.
Hey I would love to work on this issue. Could you please provide some more information on it?
Thanks! What additional information do you need exactly?
@rahil1304 I just realized that @MarceloZapatta already made a PR, sorry about that.
@HackbrettXXX Hi this issue has been resolved since 3 years can you close it ?