Christian Stewart

Results 382 comments of Christian Stewart

@L11R FYI the epic for that is here: https://gitlab.com/groups/gitlab-org/-/epics/9092

@tinanemati You can use the forked version by replacing imports of `chonky` with the fork `@aperturerobotics/chonky`. See: https://github.com/aperturerobotics/react-chonky/tree/master#usage Hope that helps.

@tinanemati ``` import { setChonkyDefaults } from "@aperturerobotics/chonky"; import { ChonkyIconFA } from "@aperturerobotics/chonky-icon-fontawesome"; import { FullFileBrowser } from "@aperturerobotics/chonky"; import { ChonkyActions, FileHelper } from "@aperturerobotics/chonky"; ```

In RenameIndex, the function is defined in the interface as: ``` // RenameIndex renames an existing index to another name that is not already taken by another index on this...

In `createIndex` in the memory/ package, the DB ID is always set to "" (at line 1426) - why, shouldn't it be set to the db name?

In the table index, createIndex is passed a list of columns, `[]sql.IndexColumn` and an expression is built to select each column. Is it necessary for the underlying storage driver to...

In the table index, the `errIfDuplicateEntryExist` function iterates over _all rows of all partitions_ which seems like it's definitely not intended to be the behavior that a "production grade" implementation...

I guess most of this can be chalked up to https://github.com/dolthub/go-mysql-server/issues/1347 - that the in-memory indexes are currently pretty much unimplemented.

Changes the collision detection but not the positioning.