PPJA icon indicating copy to clipboard operation
PPJA copied to clipboard

Excessive Nesting in Harvested Drops for DGA Fresh Meat

Open scriptsforweirdos opened this issue 1 year ago • 0 comments

Looking at [PPJA] Fresh Meat/[DGA] Fresh Meat/crops.json.

I'm seeing what appears to be excessive nesting in the HarvestedDrops Params.

Example:

"HarvestedDrops": [
     {
	"MaximumHarvestedQuantity": 2,
	"ExtraQuantityChance": 0.1,
	"Item": [
			{
				"Weight": 1.0,
				"Value": {
					"Value": "ppja.freshmeat.DGA/Alpaca Meat"
				}
			},
			{
				"MinimumHarvestedQuantity": 1,
				"MaximumHarvestedQuantity": 1,
				"ExtraChance": 0.1,
				"Item": [
					{
						"Weight": 1,
						"Value": null
					},
					{
						"Weight": 1,
						"Value": {
							"Value": "ppja.freshmeat.DGA/Alpaca Fell",
						}
					},
				]
			}
		]
	}
 ],

Should probably instead be:

"HarvestedDrops": [
	{
		"MaximumHarvestedQuantity": 2,
		"ExtraQuantityChance": 0.1,
		"Item": [
					{
						"Weight": 1.0,
						"Value": {
							"Value": "ppja.freshmeat.DGA/Alpaca Meat"
						}
					},
				]
	},
	{
		"MinimumHarvestedQuantity": 1,
		"MaximumHarvestedQuantity": 1,
		"ExtraChance": 0.1,
		"Item": [
			{
				"Weight": 1,
				"Value": null
			},
			{
				"Weight": 1,
				"Value": {
					"Value": "ppja.freshmeat.DGA/Alpaca Fell",
				}
			},
		]
	}
],

Also I suspect "ExtraChance" in the doubly-nested node should be "ExtraQuantityChance" but the converter didn't run deep enough to catch the string conversion.

scriptsforweirdos avatar Sep 07 '23 00:09 scriptsforweirdos