inky icon indicating copy to clipboard operation
inky copied to clipboard

Update commands to be in line with current Python Inky

Open lawik opened this issue 5 years ago • 3 comments

A bunch of magical numbers, voltages and stuff have been changed.

Example, the stuff sent for the yellow display specifics has been changed: https://github.com/pimoroni/inky/commit/8165ca0f43c22f54fd6d018a816df4ab37fa92f0

So we should get up to scratch with that.

lawik avatar Jul 25 '19 09:07 lawik

Does this include #9?

nyaray avatar Jul 26 '19 08:07 nyaray

It could. But it doesn't have to. I think #9 would be worth doing on its own, has some additional requirements (reading the EEPROM iirc). So I'd say keeping them separate makes things easier.

This could probably just be a straight pass to adjust our numbers to be in line with the tweaks they seem to have made. From what I've seen, some things like yellow color temperature by passing different stuff for the yellow-specific commands seem to have been changed.

lawik avatar Jul 26 '19 10:07 lawik

Sounds good, agreed.

nyaray avatar Jul 26 '19 11:07 nyaray