PaperWM icon indicating copy to clipboard operation
PaperWM copied to clipboard

Gnome 46 testing issues

Open darix opened this issue 1 year ago • 1 comments

Describe the bug

Extension [email protected]: TypeError: MessageTray.SystemNotificationSource is not a constructor

Stack trace:
  notify@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:212:22
  errorNotification@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:232:35
  enableUserConfig@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:162:22
  enable@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:61:14
  _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:263:38
  async*_onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:621:24
  _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:726:18
  createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:730:46
  enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:286:29
  EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:453:38
  _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:329:38
  _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
  @resource:///org/gnome/shell/ui/init.js:21:20

To Reproduce

try to load the extension in gnome 46

Example:
Distribution: openSUSE Tumbleweed + GNOME:Next
GNOME Shell 46.beta
PaperWM branch/tag: 45.9.1
PaperWM commit: 45.9.1
Enabled extensions:
- [email protected]
- [email protected]
- [email protected]

darix avatar Feb 15 '24 01:02 darix

Cheers, note, I'm not planning on working on Gnome 46 compatibility for a few weeks (noting the release date is March 20th).

Also, hopefully Gnome will release their extension port writeup soon (e.g. https://gjs.guide/extensions/upgrading/gnome-shell-45.html).

jtaala avatar Feb 18 '24 11:02 jtaala

Hey @darix,

I've now pushed up a gnome-46 for testing. Are you able to check this out and give it a whirl?

Note is compatible with Gnome 45 & 46. Cheers.

git checkout gnome-46
./install.sh

Then login/logout.

jtaala avatar Mar 14 '24 10:03 jtaala

actually turning on the extension in the session worked already. no login needed as it was not running before:

#PaperWM enabled
clutter_actor_allocate: assertion '!isnan (real_allocation.x1) && !isnan (real_allocation.x2) && !isnan (real_allocation.y1) && !isnan (real_allocation.y2)' failed
clutter_actor_allocate: assertion '!isnan (real_allocation.x1) && !isnan (real_allocation.x2) && !isnan (real_allocation.y1) && !isnan (real_allocation.y2)' failed
Can't update stage views actor panel [Gjs_paperwm_paperwm_github_com_topbar_FocusIcon] is on because it needs an allocation.
Can't update stage views actor unnamed [ClutterActor] is on because it needs an allocation.
Can't update stage views actor unnamed [StLabel] is on because it needs an allocation.
Can't update stage views actor unnamed [ClutterText] is on because it needs an allocation.
cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed
Window manager warning: Overwriting existing binding of keysym 35 with keysym 35 (keycode e).
Window manager warning: Overwriting existing binding of keysym 36 with keysym 36 (keycode f).
Window manager warning: Overwriting existing binding of keysym 37 with keysym 37 (keycode 10).
Window manager warning: Overwriting existing binding of keysym 38 with keysym 38 (keycode 11).
Window manager warning: Overwriting existing binding of keysym 39 with keysym 39 (keycode 12).
Window manager warning: Overwriting existing binding of keysym 6f with keysym 6f (keycode 20).
]: JS LOG: Characters Application exiting
#PaperWM disabled
Window manager warning: Overwriting existing binding of keysym 35 with keysym 35 (keycode e).
Window manager warning: Overwriting existing binding of keysym 38 with keysym 38 (keycode 11).
Window manager warning: Overwriting existing binding of keysym 39 with keysym 39 (keycode 12).
Window manager warning: Overwriting existing binding of keysym 36 with keysym 36 (keycode f).
Window manager warning: Overwriting existing binding of keysym 37 with keysym 37 (keycode 10).

darix avatar Mar 14 '24 11:03 darix

the keycode warnings also happen when logging in the with the extension. just the clutter warnings and cogl problems do not happen.

darix avatar Mar 14 '24 11:03 darix

Cheers, any actual issues seen or functions not working?

The keycode and allocation warnings/outputs are pretty benign. The FocusIcon one is interesting, does the Focus mode icon show okay?

jtaala avatar Mar 14 '24 11:03 jtaala

well the basic functionality seems to work. I have to admit I only packaged PaperWM a few days before switching to 46 for testing. and i havent really used paperwm. but of course when we test a newer gnome release we also test extensions and open bugs. :)

but basic functionally worked and i could use apps with paperwm enabled.

darix avatar Mar 14 '24 12:03 darix

admit I only packaged PaperWM a few days before

Packaged?

jtaala avatar Mar 14 '24 14:03 jtaala

https://build.opensuse.org/package/show/home:darix:playground/gnome-shell-extension-PaperWM

darix avatar Mar 14 '24 14:03 darix

Hey @darix, just a note that we've now released a Gnome 46 version that fixed quite a few bugs (one big one). We're now at v46.2.0.

It's now in the release branch.

jtaala avatar Mar 29 '24 12:03 jtaala

Thank you. updated my package. might put it into a project where it can be found more easily by users later.

darix avatar Mar 29 '24 17:03 darix