remote_syslog2 icon indicating copy to clipboard operation
remote_syslog2 copied to clipboard

OSX 10.7.5 Lion support

Open tuupola opened this issue 9 years ago • 6 comments

The Darwin binaries do not seem to support older OSX versions. Tested with OSX 10.7.5 and 0.14 release of remote syslog. Running the binary dies with Illegal instruction: 4.

Apparently adding -mmacosx-version-min=10.7 flag during compile time might fix the problem.

$ bin/remote_syslog 
Illegal instruction: 4
$ sw_vers 
ProductName:    Mac OS X
ProductVersion: 10.7.5
BuildVersion:   11G63
$ uname -a
Darwin salesman.local 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64

tuupola avatar Oct 02 '15 11:10 tuupola

Compiling the binaries with following fixed problem for me.

$ setenv MACOSX_DEPLOYMENT_TARGET 10.7
$ make

tuupola avatar Oct 02 '15 12:10 tuupola

Thanks, @tuupola. Let me play with this to see what effect it has. Assuming all is well, I'll apply one of the suggested fixes and merge.

leonsodhi avatar Oct 02 '15 21:10 leonsodhi

Putting my $0.02 here. Dropping compile compatibility that low could introduce performance issues for remote_syslog2 on OS X. I can't remember where I read it but there were some notable perf optimization additions to the complier and linkers for 10.8 that are not backwards compatible. (source, Apple Developer membership required: https://devforums.apple.com/message/773142)

johlym avatar Jun 14 '16 22:06 johlym

@troy would love your $0.02 here, too. It's also worth noting that 10.7 isn't going to get any new updates (security or otherwise; the last I think was 2012) and I think even 10.8 is out to pasture, too. Is the user base large enough to warrant a separate OS X build?

johlym avatar Jun 14 '16 22:06 johlym

  • OS X build of any kind: yes
  • minimum supported version: 10.7 is so prehistoric that no one is using it for something close to production. 10.9 is still actively used. I'm indifferent about 10.8, but if we don't know of any specific optimizations which are only possible by targeting 10.9+, I lean towards continuing to support 10.8.

IMO, our default should be the broadest possible support unless something - like the 10.8+ optimizations you mentioned - is more valuable.

troy avatar Jun 15 '16 14:06 troy

I don't mind creating a separate build for 10.7. I can just label it as such. I'm sure there are still people that use 10.7 but I don't want to potentially bring down the rest of the group with what would be for them a slower binary.

johlym avatar Jun 15 '16 17:06 johlym