remote_syslog2 icon indicating copy to clipboard operation
remote_syslog2 copied to clipboard

Ignore binary data to avoid r_s2 stalling

Open leonsodhi opened this issue 9 years ago • 5 comments

No idea how to do this, and the first step is figuring out how to reliably repro it.

leonsodhi avatar Jan 30 '16 03:01 leonsodhi

I could see a default maximum of 25,000 characters per line or something. I think messages longer than that are very likely to be binary, rather than stringified JSON hashes.

troy avatar Jan 30 '16 16:01 troy

@leonsodhi How big of an issue is this, still?

johlym avatar Jun 14 '16 22:06 johlym

Not sure. Only had one confirmed case of it although I have heard of people accidentally logging email attachments in the past. I'd be inclined to consider this low priority and leave the issue as-is. No strong opinion, though.

leonsodhi avatar Jun 14 '16 22:06 leonsodhi

For the sake of completeness, I'd argue either doing something about it or closing it #wontfix. That's just how I roll, though.

johlym avatar Jun 14 '16 23:06 johlym

I confirmed that it's stalling on the latest version, so I can take a look.

snorecone avatar Nov 23 '16 19:11 snorecone