papertrail-cli icon indicating copy to clipboard operation
papertrail-cli copied to clipboard

GPA Improvements: 1.15 to 2.02

Open DannyBen opened this issue 8 years ago • 3 comments

An assortment of small to medium changes to improve code standards:

  1. Exclude okjson from Code Climate
  2. Remove / rename unused variables, mostly in the OptionsParser blocks
  3. Add configfile method to CliHelpers to avoid repeating the confusing condition+assignment if configfile = find_configfile
  4. Reduce code duplication in http_client by adding an attempt times, wait, &block method to handle HTTP retries in a single place.

CC: #78

DannyBen avatar Aug 09 '16 15:08 DannyBen

Looks great!

gj1

lmarburger avatar Aug 11 '16 14:08 lmarburger

Agree with everything, had the same thoughts on all subjects. The global rescue in the attempt method is a mistake on my part. Will update later today.

DannyBen avatar Aug 11 '16 14:08 DannyBen

I'll give this a run through next week before merging and cutting a release.

lmarburger avatar Aug 19 '16 13:08 lmarburger