papertrail-cli
papertrail-cli copied to clipboard
GPA Improvements: 1.15 to 2.02
An assortment of small to medium changes to improve code standards:
- Exclude
okjson
from Code Climate - Remove / rename unused variables, mostly in the
OptionsParser
blocks - Add
configfile
method toCliHelpers
to avoid repeating the confusing condition+assignmentif configfile = find_configfile
- Reduce code duplication in
http_client
by adding anattempt times, wait, &block
method to handle HTTP retries in a single place.
CC: #78
Looks great!
Agree with everything, had the same thoughts on all subjects. The global rescue
in the attempt method is a mistake on my part. Will update later today.
I'll give this a run through next week before merging and cutting a release.