paper-plane
paper-plane copied to clipboard
paper-plane-developers
message-indicators: Show reply count
~~This shows a higher reply count than tdesktop does. Maybe because it also counts the indirect replies, as the doc for reply_count states "Number of times the message was directly or indirectly replied"?~~
It seems it was a problem with tdesktop receiving delayed updates. Now I can't spot a difference in the reply count.
Also, it should be clarified whether InteractionInfo should rather be a GObject.
Also, it should be clarified whether InteractionInfo should rather be a GObject.
I think we'll most likely need this to be a gobject for the future because we'll want e.g. a GListModel as the list of the reactions. I suggest creating a simple gobject with just the properties you need for now.
BTW, feel free to create branches in the repo directly if you want, so that it's also easier for me to checkout them :) You can prefix them with your username so that they appear more separated from mine.
BTW, feel free to create branches in the repo directly if you want, so that it's also easier for me to checkout them :) You can prefix them with your username so that they appear more separated from mine.
Yes, good Idea.
I think we'll most likely need this to be a gobject for the future because we'll want e.g. a GListModel as the list of the reactions. I suggest creating a simple gobject with just the properties you need for now.
Done. The question was whether we want to flatten everything into Message or keep the hierarchy like in tdlib (Message -> MessageInteractionInfo -> MessageReplyInfo).
For now, I tried to keep the hierarchy.
Sorry for the wait.
This is nice to have, but it now needs a rebase to fix conflicts.
I had a look at MessageReplyInfo properties and it doesn't seem to be anything useful to make a custom gobject. I suggest just moving the reply-count property to MessageInteractionInfo for now.
It seems that the reply count is appearing in channel messages, but the design in there should be different:
Telegram Desktop
This branch
I guess that it's better hiding the reply_count box for channels for now.