Andreas Lind

Results 190 comments of Andreas Lind

@dougwilson, that sounds fair! Does it look good otherwise?

Fixed conflict with master. @dougwilson, this has been sitting for some time now :sweat_smile: I'm not really in a hurry, but how about getting this released soon? I can remove...

Okay, thanks for the update, that makes sense! > If this could be made to work in those node.js versions I would of course be happy to land right away....

Resolved the conflict and updated to 6.9.4 :innocent:

@Xtrem65, I guess the only update is that you're expressing interest, which is also a good thing :) If @dougwilson and @ljharb think the work looks good and they want...

@Xtrem65, have you tried switching to my `body-parser-papandreou` fork to see if it solves your problem? It should still work with current versions of express.

@ljharb, that sounds great. Before I try to rebase it on qs master, does this approach look good? https://github.com/papandreou/qs/compare/9250c4cda5102fcf72441445816e6d311fc6813d...interpretNumericEntities

Rebased branch: https://github.com/papandreou/body-parser/tree/feature/iso-8859-1/take2 Requires https://github.com/ljharb/qs/pull/268 to be `npm link`ed in.

@Xtrem65, you can help by trying it out :) 1. Make a clone of https://github.com/papandreou/qs 2. Check out the `feature/iso8859-1` branch 3. `npm link` 4. Make a clone of https://github.com/papandreou/body-parser...

The breaking change was: - [drop support for node <6 \(\#419\)](https://github.com/estools/escodegen/commit/ff550a81aad45b85510275632c1262619d6242d3) ([Timofey Kachalov](mailto:[email protected])) And this one also landed: - [add support for optional chaining \(\#412\)](https://github.com/estools/escodegen/commit/1d192aef5d6bd42c960e4426bc84bcb161318df9) ([Timofey Kachalov](mailto:[email protected]))