ServiceBusExplorer icon indicating copy to clipboard operation
ServiceBusExplorer copied to clipboard

Support dark theme

Open kkorus opened this issue 6 years ago • 19 comments

Can you add option for Dark Theme?

kkorus avatar Feb 05 '19 16:02 kkorus

Hi @kkorus love this idea, any ideas for colors? Any reference or sample?

paolosalvatori avatar Feb 05 '19 22:02 paolosalvatori

@paolosalvatori Something like here https://git-fork.com/ It supports light and dark theme.

kkorus avatar Feb 06 '19 09:02 kkorus

Do you have bandwidth to implement this feature? I've a very limited spare time in this period :(

paolosalvatori avatar Mar 04 '19 07:03 paolosalvatori

@gitricharde is already working on this.

ErikMogensen avatar Mar 04 '19 18:03 ErikMogensen

Is @gitricharde still working on this or is it currently not being worked on?

DavidSchor avatar Dec 17 '19 09:12 DavidSchor

As far as I know he is not working on it anymore, nor is anyone else. You are more than welcome to implement it.

ErikMogensen avatar Dec 17 '19 09:12 ErikMogensen

@DavidSchor Please feel free to carry on 👍

gitricharde avatar Dec 17 '19 10:12 gitricharde

I'm closing the issue for now, feel free to reopen it or submit a PR :)

paolosalvatori avatar Jan 17 '20 11:01 paolosalvatori

Yes, that is probably best. I was hoping to take a look at it during the holiday, but didn't. I am having a bit of crunch time at work now, so it would be a while before I get a chance to look at it.

DavidSchor avatar Jan 17 '20 11:01 DavidSchor

Take your time @DavidSchor and thanks for the collaboration!

paolosalvatori avatar Jan 17 '20 11:01 paolosalvatori

I've started using ServiceBusExplorer daily and would love to have a dark mode.

Can I go right ahead and make one and create a PR?

JohnHallstrom avatar Sep 01 '23 13:09 JohnHallstrom

That’d be great, @JohnHallstrom

SeanFeldman avatar Sep 01 '23 14:09 SeanFeldman

@JohnHallstrom, in case you missed it, there was a PR previously for this, #306.

ErikMogensen avatar Sep 01 '23 14:09 ErikMogensen

@JohnHallstrom, in case you missed it, there was a PR previously for this, #306.

Thanks for the heads-up!

JohnHallstrom avatar Sep 04 '23 05:09 JohnHallstrom