AppIntro icon indicating copy to clipboard operation
AppIntro copied to clipboard

Add Lottie support for images

Open mladenbabic opened this issue 5 years ago • 8 comments

It would be great if you could include the Lottie animation support for images out of the box. Thanks

mladenbabic avatar Jan 25 '20 16:01 mladenbabic

Thanks for the feature request @mladenbabic

You can use a custom layout Fragment in AppIntro, and provide your layout with your LottieAnimationView.

I think that wrapping lottie inside AppIntro is not going to be a good idea, given the impact on the user base. If we really want to have this we can think about having an external appintro-lottie module (in a similar way as I was doing in #675)

cortinico avatar Jan 25 '20 17:01 cortinico

Thanks for the quick response. Yes, I'm aware of the custom layout and I have done as you suggested. I thought that it could be nice if you can instead of drawable pass Lottie res in the constructor without any additional works. Thanks anyway.

mladenbabic avatar Jan 25 '20 17:01 mladenbabic

+1 for a appintro-lottie module. Not a big fan of having Lottie dependencies inside AppIntro main package. @mladenbabic If you want to work on it feel free to propose a PR :+1:

paolorotolo avatar Jan 26 '20 11:01 paolorotolo

We could also exploit Kotlin extension functions for this and add additional functionalities to the base module.

paolorotolo avatar Jan 26 '20 11:01 paolorotolo

Ok, cool. Currently, I'm on one huge project, so when I get more time I can start with the Lottie module.

mladenbabic avatar Jan 26 '20 21:01 mladenbabic

Thanks for the feature request @mladenbabic

You can use a custom layout Fragment in AppIntro, and provide your layout with your LottieAnimationView.

I think that wrapping lottie inside AppIntro is not going to be a good idea, given the impact on the user base. If we really want to have this we can think about having an external appintro-lottie module (in a similar way as I was doing in #675)

Hi, first of all; Wonderfull job on this library. I love it! My issue was; i wonder why i can't use more than custom layout fragment?

Levanda85 avatar Dec 15 '21 16:12 Levanda85

My issue was; i wonder why i can't use more than custom layout fragment?

That's offtopic. Please open a separate discussion and explains your issue providing some examples/reproducers.

cortinico avatar Dec 15 '21 19:12 cortinico

@mladenbabic did you ever get to add Lottie support to your own app intro or start work on a module? I'm a bit hesitant to create XMLs for all my slides just to have a Lottie animation in them but I also don't know how complex such a module as proposed here would be.

moertel avatar Jun 05 '23 06:06 moertel