rusty-s3 icon indicating copy to clipboard operation
rusty-s3 copied to clipboard

Use trait for HMAC

Open seanaye opened this issue 2 years ago • 1 comments

I am using this as a wasm module in js server runtime. I think changing the HMAC signing to a trait based approach would allow wasm binaries to leverage window.crypto for HMAC signing instead of the hmac crate. This would reduce bundle size and increase compat wit wasm.

Will make PR for this

seanaye avatar May 26 '23 13:05 seanaye

Sounds good. I wander whether it'd be better to go for a trait or instead have a Cargo.toml feature for deciding which crypto backend to use.

paolobarbolini avatar May 27 '23 04:05 paolobarbolini