mlbgame icon indicating copy to clipboard operation
mlbgame copied to clipboard

Add Current Situational Data

Open bfox6 opened this issue 6 years ago • 4 comments

Add data such as the current batter and pitcher.

Could possibly be added to the Overview class.

bfox6 avatar Mar 30 '18 03:03 bfox6

@trevor-viljoen I don't really have time to do this, would you like to take a look at this?

panzarino avatar Apr 01 '18 07:04 panzarino

I believe Trevor is working on this, this was a feature he requested in the scoreboard Slack channel

ajbowler avatar Apr 01 '18 15:04 ajbowler

@panzarino I'll try to get to it this week. I spent most of the day trying to refactor stats.py to fix the code climate findings. I think I have a solution, but there are a couple bugs I'm trying to track down with it.

trevor-viljoen avatar Apr 02 '18 06:04 trevor-viljoen

@ajbowler @panzarino @bfox6 I've got code for this I will be working into a PR. It will get all elements and attributes from the linescore.xml files and make them available as python objects.

This will include the linescore, home_runs, situational_data (see below), winning_pitcher, losing_pitcher, save_pitcher, game_media, and reviews (how many challenges remain).

situational_tags = ['current_batter', 'current_ondeck', 'current_inhole',
                    'due_up_batter', 'due_up_ondeck', 'due_up_inhole', 
                    'current_pitcher', 'opposing_pitcher']

trevor-viljoen avatar Oct 13 '18 16:10 trevor-viljoen