Filip Skokan
Filip Skokan
I believe the tests belong better to `test/parallel/test-crypto-x509.js`. A test for accessing the property when there are no extensions would also be welcome. Not being familiar with extensions myself so...
I am unfamiliar with the underlying implementation.
@mertcanaltin I am really not able to be of that kind of assistance.
@tniessen can you take a look?
Aside from my above suggestion to fix and simplify the docs entry I believe this lacks sufficient test coverage. Note that I can not review the c++ implementation
The asan detected leak is not introduced by the fixes. It's the updated wpts that run into a branch with a memory leak that was fixed in #43202. We can...
cc @nodejs/backporters
@danielleadams there was 16.x minor release 4 days ago... There's another one planned for tuesday 4/4?
cc @nodejs/crypto
This is no longer likely to make an impact on v16.x LTS with its EOL in ~6 week