libfyaml Problem: fy_node_compare_user does not recurse with itself

Problem: fy_node_compare_user does not recurse with itself

Open yrashk opened this issue 1 year ago • 6 comments

Instead, it recurses with fy_node_compare which, in effect, "loses" user settings.

Solution: make it user the user flavour of the function

Jun 19 '23 03:06 yrashk

Bumping this up as this seems to be a rather important bug (incomplete comparison using user-supplied comparison methods)

Sep 20 '23 13:09 yrashk

Any chance this can be reviewed, as it fixes a rather important bug for user-supplied comparisons? Thank you!

(Ideally, together with #87)

Oct 12 '23 14:10 yrashk

Is there any chance for this to get reviewed? It seems to be a pretty critical piece for user-supplied comparison.

Dec 05 '23 15:12 yrashk

Will take a look, seems harmless enough

Dec 05 '23 15:12 pantoniou

Bumping this issue up. Any chance for a review? Thanks! Happy New Year :)

Jan 14 '24 17:01 yrashk

Bumping this issue up as it is fairly critical.

Feb 29 '24 18:02 yrashk

Thank you!

Apr 22 '24 17:04 yrashk