wp-native-php-sessions Session callback must have a return value of type bool, null returned

Session callback must have a return value of type bool, null returned

Open olegabr opened this issue 1 year ago • 3 comments

https://github.com/pantheon-systems/wp-native-php-sessions/blob/a1fa5e03808fdef0f393569d409cf55f1bbc1dc4/inc/class-session-handler.php#L89

Just return false here?

Jul 02 '23 06:07 olegabr

Thanks for the report. As a quick clarification, what is the calling code that produces the error?

Jul 05 '23 14:07 rwagner00

It is better to return true there actually, or an error would be reported.

I do not have any specific calling code for this. It is just called normally from WordPress internals.

Aug 04 '23 02:08 olegabr

I just ran into this during a site upgrade to PHP 8.2. Any chance the fix could be merged into the next plugin update?

Dec 18 '23 15:12 paulpullen