terminus icon indicating copy to clipboard operation
terminus copied to clipboard

Address PHP exception on `local:commitAndPush`

Open vfalconisumo opened this issue 3 months ago • 3 comments

When running local:commitAndPush, Terminus throws an exception because commitAndPush expects to return a string, but the function actually returns a void because it lacks a return statement.

This exception breaks our CI pipeline because it throws on both successful and unsuccessful runs of commitAndPush, and suppressing the error would end up hiding legitimate errors.

vfalconisumo avatar Sep 18 '25 22:09 vfalconisumo

@greg-1-anderson will review/merge assuming tests pass.

stevector avatar Sep 22 '25 21:09 stevector

I tried to push a changelog note but only succeeded in creating a new branch instead. @vfalconisumo (or someone here who knows how to use GitHub better than me 🤦🏻 ), could you pull in the commits here to the forked branch (or just push a new log update)?

pwtyler avatar Sep 23 '25 22:09 pwtyler

@pwtyler I believe I was able to pull those commits into my branch this morning. Let me know if I failed miserably though :)

vfalconisumo avatar Oct 03 '25 15:10 vfalconisumo