documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Single Sign-on with Pantheon Doc Update

Open titomarifrancis-pantheon opened this issue 1 year ago • 1 comments

Re: Single Sign-on with Pantheon

Priority: High

Issue Description:

The line that says: The user_id attribute must be configured to be sent manually. If this value is not already present, it should be set to match the email attribute

contains the word "must" which means it's imperative that this step be performed as well, rather than be an optional additional step of the process.

This is pointed out by a customer, and hereby requested for the documentation to be updated

Suggested Resolution

Move this line: The user_id attribute must be configured to be sent manually. If this value is not already present, it should be set to match the email attribute.

from Additional configuration details section to another enumerated item after Add an Attribute Statement

@jazzsequence can you take a pass at updating this doc? We'll need review from someone in technical solutions or a similar area.

stevector avatar Oct 02 '24 15:10 stevector

I don't know that I agree that the Additional configuration details section implies "optional" configuration. In fact, there is a line in Additional configuration details that is optional, which says to me that everything else that's not flagged as "optional" is, in fact, required.

I will open a PR that moves this line to the top of the Additional configuration details section and bolds the "Optional" line before the optional configuration to make this somewhat clearer.

jazzsequence avatar Jul 22 '25 16:07 jazzsequence