documentation icon indicating copy to clipboard operation
documentation copied to clipboard

WIP: Nested cert nav

Open stevector opened this issue 1 year ago • 9 comments

I'm starting to try out a nested sidebar

Screenshot 2024-06-13 at 4 57 12 PM

stevector avatar Jun 13 '24 21:06 stevector

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jun 13 '24 22:06 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jun 13 '24 22:06 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jun 21 '24 15:06 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jun 26 '24 16:06 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 01 '24 22:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 01 '24 23:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 04 '24 04:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 04 '24 05:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 04 '24 05:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 10 '24 02:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 10 '24 16:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 10 '24 16:07 pantheon-decoupled[bot]

@mel-miller, when you have time, can you review how I've implemented the nested sidebar here?

stevector avatar Jul 10 '24 16:07 stevector

@stevector -- I don't see any problems with the code and the way that the nav is implemented. 👍 I did have a few small design corrections though. I've indicated them within this screenshot.

  1. For where the red line is along the menu top and right sides, just match the same amount of spacing in the main section (circled in red).
  2. For the external link indicator, it should be after the text instead of before it and use the externalLink variant of the PDS icon component.
Screenshot 2024-07-16 at 6 29 37 PM

mel-miller avatar Jul 17 '24 01:07 mel-miller

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 24 '24 18:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 24 '24 19:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 24 '24 20:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 24 '24 21:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 24 '24 21:07 pantheon-decoupled[bot]

@mel-miller, thanks! I've added padding and switched the icon. LMK what you think

https://pr-9047-documentation.appa.pantheon.site/certification/study-guide https://pr-9047-documentation.appa.pantheon.site/guides/decoupled/overview

stevector avatar Jul 24 '24 22:07 stevector

@stevector -- padding looks good. The icon should be after the text and probably one size smaller.

mel-miller avatar Jul 24 '24 22:07 mel-miller

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 24 '24 22:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Aug 08 '24 20:08 pantheon-decoupled[bot]

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 0 0 0 0
Vulnerabilities 0 0 0 0 0 0
Sensitive Data 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 0 0 0 0 0

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

wiz-inc-b08cf2810f[bot] avatar Aug 16 '24 21:08 wiz-inc-b08cf2810f[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Aug 16 '24 21:08 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Oct 07 '24 22:10 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Oct 07 '24 22:10 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Oct 07 '24 22:10 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Oct 07 '24 22:10 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-9047-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Oct 07 '24 22:10 pantheon-decoupled[bot]