documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Update modules-known-issues.md

Open pete-cleary opened this issue 1 year ago • 10 comments

There are no more known issues for the module: "Simple OAuth / OAuth 2.0 Issue: The module requires a very specific set of permissions for the folder and the keys to be uploaded. Using Private or non-standard filepaths won't work. It is not possible to change these in LIVE or TEST environment.

Solution: You can try to patch the permission check in the module. The alternative is to use off-site key management tools like Lockr"

The module now works without a workaround.

Closes #

Summary

Doc Page Title - <Enter a one sentence summation of the pertinent changes (including not-yet-completed work) provided by this PR.>

Effect

The following changes are already committed:

Remaining Work and Prerequisites

The following changes still need to be completed:

  • [ ] List any outstanding work here

Dependencies and Timing

  • [ ] Other prerequisites that must be completed before merging this PR

Release:

  • [ ] When ready
  • [ ] After date: $DATE

Post Launch

Do not remove - To be completed by the docs team upon merge:

  • [ ] Redirect /old-path/ => /new-path/ (if applicable)
  • [ ] Include/exclude pages ^ respectively within docs search service provider (if applicable)
  • [ ] For Heroes - add a props post to the discussion board.
  • [ ] Remove from the project board

pete-cleary avatar Jan 23 '24 17:01 pete-cleary

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-8836-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jan 23 '24 17:01 pantheon-decoupled[bot]

@ryanshoover can you assign someone from your team to review?

rachelwhitton avatar Apr 23 '24 15:04 rachelwhitton

this is still an issue and we should recommend the patches to oauth which been tested / validated by other Pantheon customers: https://github.com/lcatlett/oauth2-server/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc

Patch links: PHP8: https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/1.patch PHP7: https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/2.patch

lcatlett avatar Apr 23 '24 16:04 lcatlett

@lcatlett are these patches something you expect to contribute upstream to the main project thephpleague/oauth2-server ?

rachelwhitton avatar Apr 23 '24 17:04 rachelwhitton

@rachelwhitton can you update this PR to tell customers that these patches are needed (and how to apply them)?

stevector avatar Jun 12 '24 16:06 stevector

@stevector done! reassigned this one to you for next steps

rachelwhitton avatar Jun 12 '24 17:06 rachelwhitton

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-8836-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jun 12 '24 17:06 pantheon-decoupled[bot]

@rachelwhitton can you review?

stevector avatar Jul 11 '24 18:07 stevector

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-8836-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 11 '24 21:07 pantheon-decoupled[bot]

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-8836-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jul 12 '24 16:07 pantheon-decoupled[bot]

For reasons I'm not comprehending, I'm failing to get Composer to apply patches successfully when I replicate @lcatlett's patches in https://github.com/pantheon-systems/oauth2-server/pulls

While I'd prefer the patches be sourced from a Pantheon-owned repo, I also just want to get accurate docs published (especially since the currently published version mentions Lockr). Since I've let this PR languish too long I'm going to merge as is. We can always revisit later.

stevector avatar Jan 16 '25 20:01 stevector

🎉 @pete-cleary Congrats on merging your first pull request! @pantheon-systems/docs-admins appreciates your contribution!!

If you like this project, please ⭐star⭐ our repo.

github-actions[bot] avatar Jan 16 '25 20:01 github-actions[bot]