documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Inaccurate documentation: Terminus does does not support php version 8.3+ but Pantheons documentation states it does.

Open zane-kanopi opened this issue 1 year ago • 2 comments

https://docs.pantheon.io/terminus/install

Expected behavior

  • Terminus works: terminus --version displays the version.

Actual behavior

$ terminus --version

PHP 8.3+ is not supported by this version of Terminus.
Check for new versions at https://github.com/pantheon-systems/terminus/releases

Set environment variable TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP to try continuing anyway.
Stopping.

Steps to reproduce the problem

  1. Run the above commands.

Suggested Resolution

  • Update documentation to note 8.3 is not supported.

Current docs state:

PHP Version 7.4 or later reference: https://docs.pantheon.io/terminus/install#required-packages

Screenshot 2024-01-18 at 11 52 58 AM

zane-kanopi avatar Jan 18 '24 16:01 zane-kanopi

Should this be moved to the Terminus issue queue, or the issue title updated to clarify it's about Terminus and not Pantheon hosting itself?

damienmckenna avatar Jan 24 '24 15:01 damienmckenna

Should this be moved to the Terminus issue queue, or the issue title updated to clarify it's about Terminus and not Pantheon hosting itself?

@damienmckenna specifically this is about Pantheons hosting documentation (hence its on the Pantheon Systems Documentation repo) on regarding their Terminus product.

I've updated the description to better reflect a solution that only involves updating documentation along with updating the description to show this is in reference to the documentation.

zane-kanopi avatar Jan 24 '24 15:01 zane-kanopi

It looks like this issue was fixed here: https://github.com/pantheon-systems/terminus/pull/2517/files

On my local machine I'm seeing:

terminus --version

Terminus 3.3.5

and

 php -v
PHP 8.3.4 (cli) (built: Mar 12 2024 23:42:26) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.4, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.4, Copyright (c), by Zend Technologies

Please re-open if there's still a problem

stevector avatar Jul 10 '24 19:07 stevector