documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Update the recommended s3 policy in s3 offload media

Open carl-alberto opened this issue 2 years ago • 1 comments

Closes #8730

Summary

Reviewed the policy outlined, it seems it is outdated as reported by 2 customers

Effect

The following changes are already committed:

  • updated s3 config in the PR

Remaining Work and Prerequisites

The following changes still need to be completed:

  • [ ] List any outstanding work here

Dependencies and Timing

  • [ ] Other prerequisites that must be completed before merging this PR

Release:

  • [ ] When ready
  • [ ] After date: $DATE

Post Launch

Do not remove - To be completed by the docs team upon merge:

  • [ ] Redirect /old-path/ => /new-path/ (if applicable)
  • [ ] Include/exclude pages ^ respectively within docs search service provider (if applicable)
  • [ ] For Heroes - add a props post to the discussion board.
  • [ ] Remove from the project board

carl-alberto avatar Oct 10 '23 14:10 carl-alberto

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-8731-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Oct 10 '23 14:10 pantheon-decoupled[bot]

@carl-alberto who else can review the accuracy of the change? I don't have the subject matter expertise to do so myself.

stevector avatar Mar 28 '24 14:03 stevector

@stevector hi! I have verified that these settings do work. I tested on my sandbox site, and the files are directly offloaded to the S3 bucket. It should be noted that this PR removes access to list the buckets, which is an option with the WP Offload Media plugin. Can we rely on customers to copy/paste their bucket name appropriately for configuration? Since the bucket listing is a feature in the plugin, this gives me pause at face value.

Also, the screenshot needs to be updated.

If so, I'd say this is a pass (save for the screenshot). If not, I can play around with the permissions and get the bucket listing going.

miriamgoldman avatar Jun 12 '24 18:06 miriamgoldman

Can we rely on customers to copy/paste their bucket name appropriately for configuration?

I've never used this plugin, but I just based on the level of prescriptive detail already in this page of Docs, I think that if we tell the reader that they need to copy/paste the bucket name that it'll be fine.

If you're trying this out on your own S3, can you take updated screenshots?

stevector avatar Jun 12 '24 18:06 stevector

Can we rely on customers to copy/paste their bucket name appropriately for configuration?

I've never used this plugin, but I just based on the level of prescriptive detail already in this page of Docs, I think that if we tell the reader that they need to copy/paste the bucket name that it'll be fine.

Ok, great! I wasn't sure.

If you're trying this out on your own S3, can you take updated screenshots?

Absolutely. I'll get that in tomorrow and tag you here/in Slack.

miriamgoldman avatar Jun 12 '24 20:06 miriamgoldman

@stevector As I'm not a docs admin, I haven't actually hit the review button, but I've added the updated screenshot - and added a note where it talks about using the full S3 access permission regarding needing that if you want to list buckets. LGTM now. Off to you. 🙂

miriamgoldman avatar Jun 13 '24 12:06 miriamgoldman

I'm removing the old .png and will review more once the preview deployment completes.

stevector avatar Jun 13 '24 20:06 stevector

I'm not sure why deployments are failing here, investigating.

stevector avatar Jun 14 '24 15:06 stevector

:zap: Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

:eyes: Preview: https://pr-8731-documentation.appa.pantheon.site :hammer_and_wrench: Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

pantheon-decoupled[bot] avatar Jun 14 '24 15:06 pantheon-decoupled[bot]

Thanks @miriamgoldman!!

stevector avatar Jun 14 '24 15:06 stevector