Accept terms of use

[gahermar]

Accept term of use after login for all users After change term of use set status accepted on all users to false.

[panterch]

Dear @MartinGaher

Thanks for your work - very much appreciated!

I've checked out the branch and did some acceptance testing. Here are my findings:

The following acceptance criteria seems not to be fulfilled:

Werden die Nutzungsbedingungen erneut geändert, müssen diese erneut angezeigt und akzeptiert werden

In the implementation notes there were some hints how to achive this. Feel free to find another way of implementing it, that fulfills the same criterias:

Auf dem site model soll aufgezeichnet, wann die Nutzungsbedingungen das letzte mal geändert wurden. Dies kann z.B. über den "Dirty" state des Feldes gemacht werden: https://api.rubyonrails.org/classes/ActiveRecord/AttributeMethods/Dirty.html

Auf dem User Model muss ebenfalls aufgezeichnet werden, wann Benutzer*innen das letzte Mal die Nutzungsbedingungen akzeptiert haben.

I tested by logging in as admin, accepting the tos, then changing the tos, logging out and login in again. It should have displayed me the tos again but did not.

[gahermar]

Hello @panterch , sorry for that. I usually do not enforce accept for user which making changes - it was for all other users. I repair it and now after save app wants to accept too for admin which make changes. I also added datetime to user for check last accepted date and also datetime to site for check last update date.

[gahermar]

Hi, i have question about default values. Now i changed columns in DB to have default values to datetime.now. It is ok or it is better to let it nil and do some check in code? It depends on how is user created. If there is some acceptation during creation or not or if some other user create user account?