vscode-elixir-credo icon indicating copy to clipboard operation
vscode-elixir-credo copied to clipboard
verified publisher icon pantajoe

feat: Allow to ignore error messages

Open ceolinwill opened this issue 3 years ago • 5 comments

This PR adds an ignoreErrorMessages option that allows us to ignore those Error on parsing output messages that can be quite distracting.

Closes #344

ceolinwill avatar Mar 19 '23 22:03 ceolinwill

Shouldn't the default be to ignore this error message? I don't understand what action a user is supposed to take after seeing the message, or how anyone could rely on it in their workflow.

jeremyjh avatar Apr 13 '23 23:04 jeremyjh

It depends. Even though that isn't the case here, errors should be something that requires our attention. Hence, it probably wouldn't be a good idea to hide them by default.

Ideally, we need to investigate what's causing those parsing output errors (I'm planning to investigate as soon as I have some free time but I'm new to Elixir, so I wouldn't get my hopes high that I will succeed).

In the meantime, this PR is more like a workaround to avoid distractions while the underlying issue isn't fixed.

ceolinwill avatar Apr 13 '23 23:04 ceolinwill

If a plugin isn't working as I expect it to, I look in its output for errors. Most don't pop-up a message to tell me they aren't working.

edit: not trying to be argumentative here, I appreciate you doing what you can to help with this. Its just this error really annoys me, and I never want to see it again.

jeremyjh avatar Apr 13 '23 23:04 jeremyjh

I've opened a new PR proposing that we ignore those SIGTERM erros by default. I think it's safe to ignore them and it would fix these annoying notifications.

I'm not sure it will be merged soon, though. @pantajoe mentioned he was swamped with personal and work stuff back in February.

Btw, in the meantime, you can run my branch locally:

  • Uninstall this extension to avoid conflicts with the local one.
  • Close my repo and checkout to the ignore-sigterm branch.
  • Compile the extension: yarn compile.
  • Open the command palette (Cmd + Shift + P).
  • Select the option: Developer: Install Extension from Location.
  • Choose the directory where you cloned my repo.

ceolinwill avatar Apr 14 '23 16:04 ceolinwill

in the meantime, you can run my branch locally

Thank you!! 🙏

dustinfarris avatar Apr 15 '23 01:04 dustinfarris

Thanks for your contribution @wceolin. I've recently done a complete rewrite as I'm trying to restart maintaining this project. Would you be interested to drop a PR against the up-to-date version on main? (Or simply merging main into here would be fine).

However, I don't think we should ignore all error messages. Perhaps we can assign each error message a "class"/"type" that could be ignored, so only one type of errors would be ignored?

pantajoe avatar Jun 02 '24 14:06 pantajoe

@pantajoe Awesome! I think this PR was more useful during those SIGTERM errors, not sure it’s super relevant anymore. I haven’t seen many errors lately.

I’m going to close this for now, update the extension to the latest version and, if I start seeing many errors, I may reopen this but implementing your suggestion to ignore errors by type/class.

ceolinwill avatar Jun 03 '24 17:06 ceolinwill

@pantajoe Awesome! I think this PR was more useful during those SIGTERM errors, not sure it’s super relevant anymore. I haven’t seen many errors lately.

I’m going to close this for now, update the extension to the latest version and, if I start seeing many errors, I may reopen this but implementing your suggestion to ignore errors by type/class.

Sounds fair, thanks! 👍🏽

pantajoe avatar Jun 04 '24 07:06 pantajoe