JWT and api keys authentication fixes

[mohamedsalem401]

This PR should handle two seperate issue

1. JWT: the current implementation only checks if the JWT has been signed by our secret only, and not if the JWT user is still in the database.
2. Api key: The validateApiKey service now returns a 401 Unauthorized error (instead of a 500 Internal Server Error) when an invalid or deleted API key is encountered.

[rflihxyz]

Qovery can create a Preview Environment for this PR. To trigger its creation, please post a comment with one of the following command.

Command	Blueprint environment
/qovery preview 783d0240-ec38-4387-a9a9-8e225f1bd3e1	dev
/qovery preview {all|UUID1,UUID2,...}	To preview multiple environments

---

This comment has been generated from Qovery AI :robot:. Below, a word from its wisdom :

Take rest sometimes

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 96667fbdb2baa793639811b7c7c06becb6037da8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel[bot]]

@mohamedsalem401 is attempting to deploy a commit to the Panora Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mit-27]

Hello @mohamedsalem401, actually I considered the first scenario and that is why I added the verifyUser method at the auth/profile endpoint. Could please double-check that? Thank you.

[mohamedsalem401]

Hey @mit-27, Let me check and get back to you :D

[mohamedsalem401]

The current implementation checks if the user associated with the JWT token exists in the database when calling the profile endpoint. This endpoint is used in the useUser hook.

• The pull request (PR) proposes adding this check at the guard level, so it applies to all JWT-protected endpoints, not just the profile endpoint.
• Additionally, the JWT in the useUser hook will be removed even in cases of request errors to the profile endpoint, not just authorization errors. ( This's still not addressed in this PR )

[mit-27]

The current implementation checks if the user associated with the JWT token exists in the database when calling the profile endpoint. This endpoint is used in the useUser hook.

• The pull request (PR) proposes adding this check at the guard level, so it applies to all JWT-protected endpoints, not just the profile endpoint.
• Additionally, the JWT in the useUser hook will be removed even in cases of request errors to the profile endpoint, not just authorization errors.

Yes, you are right. we need to verify the user within the guard so that it can apply to all JWT-guarded endpoints. Thanks