maximize-select2-height icon indicating copy to clipboard operation
maximize-select2-height copied to clipboard

Published 20 hours ago • verified publisher icon panorama-ed

Now it working without Uniq ID attribute on select elements

Open dirmax opened this issue 6 years ago • 3 comments

dirmax avatar Sep 20 '18 14:09 dirmax

Thanks so much for the PR, @dirmax! @parkerfinch will take a look at this tomorrow and we'll try to get it merged quickly!

JacobEvelyn avatar Sep 20 '18 18:09 JacobEvelyn

Thanks for submitting this @dirmax! We ran into a couple issues testing this out, which I think are because the .select2-results__options element can be added outside of the $(el).parent(). I added some more test cases in #16 today and when I tested out the code change here it didn't apply the maximization correctly.

Can you pull the new test.html file and make sure that your changes work as expected? I'm sorry we don't have a better way to test things out here; right now the best approach we have is to replace the script in that file with the new version and make sure the page still behaves as expected. Does that make sense, and is there anything else I can do to help you test out changes?

parkerfinch avatar Sep 21 '18 20:09 parkerfinch

?

nagyimre1980 avatar Mar 16 '23 13:03 nagyimre1980