POCS icon indicating copy to clipboard operation
POCS copied to clipboard

Handle cleanup_observations when a scheduler is removed.

Open ImmortalRabbit opened this issue 5 years ago • 1 comments

<Enter description of change or enhancement here> We want to call the cleanup_observations if the scheduler is removed manually. If we were to switch schedulers in the middle of the night we need some way to trigger this cleanup methods.

Describe the solution you'd like Don't know for sure, how to solve this problem. @wtgee said it has to made as a separate issue. Currently, I created check that stops cleanup_observations if scheduler is None.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Code changes can be found in a pull request #838 because it is still not merged with develop branch.

Related Issues/PRs If there are any related Issues or PRs list them here:

Depends on: #838
Required by:

@wtgee @jamessynge

ImmortalRabbit avatar Jun 04 '19 09:06 ImmortalRabbit

Thanks for creating the Issue. I'm not entirely sure how we want to handle this either and we probably don't need to worry about it right now, but it's good to have the Issue.

@jamessynge and I have favored moving toward a model where each image is automatically uploaded to our cloud servers as soon as it is taken, which would eliminate the need for cleanup_observations altogether.

Let's keep this Issue open but don't worry too much about it right at this point.

wtgee avatar Jun 04 '19 22:06 wtgee