POCS icon indicating copy to clipboard operation
POCS copied to clipboard

Published 20 hours ago • verified publisher icon panoptes

Inconsistency between `ccd.SDKDriver.get_devices()` and `AbstractSDKCamera._cameras` (bug)

Open danjampro opened this issue 4 years ago • 0 comments

AbstractSDKCamera._cameras are expected to have keys of camera serial_numbers, but ccd.SDKDriver creates them as name: port. This leads to an InvalidConfig error. The reason the tests are currently passing is that the device name for the ccd camera is the same as its serial number.

ccd.SDKDriver: https://github.com/panoptes/POCS/blob/804e48d3e66fb6d413aef6ac2f675349bcd0f819/src/panoptes/pocs/camera/simulator/ccd.py#L23

AbstractSDKCamera._cameras: https://github.com/panoptes/POCS/blob/804e48d3e66fb6d413aef6ac2f675349bcd0f819/src/panoptes/pocs/camera/sdk.py#L98

danjampro avatar Oct 21 '20 10:10 danjampro