vscode-liquid icon indicating copy to clipboard operation
vscode-liquid copied to clipboard

Snippet for checkbox setting has invalid default value

Open larsschellhas opened this issue 4 years ago • 2 comments

The snippet for a checkbox setting results in this code:

{
    "type": "checkbox",
    "id": "id",
    "label": "label",
    "default": "true",
    "info": ""
},

However, the default value needs to be boolean and not string - the hypens need to be removed. Furthermore, I think it would be better to remove the comma from the snippets. Much more often, I happen to have a comma too much now in my schemas instead of one to few.

larsschellhas avatar Nov 14 '20 11:11 larsschellhas

Hey @larsschellhas

I am deprecating all the snippets for Shopify schema sections in the next version (Liquify). IntelliSense capabilities will facilitate completion features for this aspect. For example:

https://user-images.githubusercontent.com/7041324/103383860-9f4c8580-4af4-11eb-8877-102831af14a1.mp4

panoply avatar Dec 30 '20 22:12 panoply

Definitely seems like a nice way of doing it! I wonder if it saves more time than having the snippets, too (at least stripped down to the required parameters). :)

Have a good start into the next year and thanks for the great work! 😊

larsschellhas avatar Dec 31 '20 11:12 larsschellhas

Will address this #121

panoply avatar Oct 27 '22 10:10 panoply