Andreas Hasenack

Results 27 comments of Andreas Hasenack

In the case of debian packaging, it's solved in `debian/rules`: ``` # Fix build on these arches (LP: #1951408) (#1000215) ifneq (,$(filter $(DEB_HOST_ARCH), armel armhf mipsel)) export DEB_CPPFLAGS_MAINT_APPEND = -DUATOMIC_NO_LINK_ERROR...

That's the Debian packaging, which we follow in Ubuntu. I debated whether to enable uring, but when I checked a bit of history, it seems it's new in glusterfs, and...

It's an environment variable, define it before the call, i.e., `CFLAGS=... ./configure` (or `CPPFLAGS=... ./configure`)

Just an example. See here for an armhf build log on ubuntu: https://launchpadlibrarian.net/582144161/buildlog_ubuntu-jammy-armhf.glusterfs_10.1-1_BUILDING.txt.gz I think this is getting out of scope for this ticket now ;)

There are a lot of whitespace changes in that commit, I suppose you mean this specific bit? https://github.com/rspamd/rspamd/commit/1338a8b9272dbea20ce0e4fee2c986bd5eeaa82b#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR471 ```diff +CHECK_LIBRARY_EXISTS(atomic __atomic_fetch_add_4 "" HAVE_LIBATOMIC) +IF (HAVE_LIBATOMIC) + list(APPEND CMAKE_REQUIRED_LIBRARIES "atomic") +endif...

I triggered a build with this change, it will take a few hours though. I'll report back.

The riscv64 build finished successfully with this patch: ```diff --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -465,6 +465,11 @@ MESSAGE(STATUS "atomic builtins are supported") ENDIF() +CHECK_LIBRARY_EXISTS(atomic __atomic_fetch_add_4 "" HAVE_LIBATOMIC) +IF (HAVE_LIBATOMIC) +...

Also works fine on my i386 sid lxd. I don't have access anymore to the arm64 host where I can spawn armhf, but it should be fine.

And on my pi3 for some reason I couldn't reproduce the build failure, unsure why...

In Ubuntu and Debian, we are now also starting to see this failure in the test suite that runs at build-time. With jupyter-client 8.6.0, this test fails: ``` ________________________ KernelAPITest.test_connections...