Andy Pan
Andy Pan
@madolson @zuiderkwast Got a minute for this?
> Can you update the PR description to mention the checks that couldn't have worked before without sys/params.h? I mean for which systems we never used accept4 but we do...
@madolson @zuiderkwast Got a minute for this?
> It looks good in general. Just a few small suggestions. > > I'm not sure it has a very big impact though. It's only used for creating the listening...
> LGTM. Can you add a test for this? And maybe for [#1616 (files)](https://github.com/libevent/libevent/pull/1616/files) as well? Working on it.
#1582 made some modifications to the test scripts, I need to add tests for this PR on top of that, therefore I think we better merge that PR first so...
The CI builds failed automatically because of no runners available, please rerun the CI. @azat
> [windows-vs-job (windows-latest, UNOCODE_TEMPORARY_DIRECTORY)](https://github.com/libevent/libevent/actions/runs/8978394872/job/24658754708?pr=1625#logs) fails It seems like there is something to do with the Unicode encoding of the temporary dir path used by this runner, I don't have a...
This [WSAENETDOWN](https://learn.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2#:~:text=A%20socket%20operation%20encountered%20a,or%20the%20local%20network%20itself.) error kept raising when the new test tried to create an `AF_UNIX` socket on the runner of (windows-latest, UNOCODE_TEMPORARY_DIRECTORY). This error seems to indicates there is something wrong...