Andy Pan

Results 356 comments of Andy Pan

Could you improve https://goreportcard.com/report/github.com/jxskiss/mcli and come back, thanks!

Please fix https://goreportcard.com/report/github.com/jxskiss/mcli, thanks!

Please fix the issues on https://goreportcard.com/report/github.com/heartwilltell/log, thanks!

Please fix [gocyclo 96%](https://goreportcard.com/report/github.com/FreeLeh/GoFreeDB#gocyclo), thanks!

Sorry for the delay, your PR is now good to go.

ThreadPoolExecutor 的拒绝策略也只是在 pool 满了之后的一些动作,用 ants 的话你可以设置 NonBlocking,这样 pool 满了之后你再调用 Submit() 就直接返回错误而非阻塞住:https://pkg.go.dev/github.com/panjf2000/ants/v2#WithNonblocking,也可以设置最大允许在等待的调用方:https://pkg.go.dev/github.com/panjf2000/ants/v2#WithMaxBlockingTasks。

Please fix the [ineffassign 92%](https://goreportcard.com/report/github.com/kdomanski/iso9660#ineffassign), thanks!

Sorry for the delay, it seems that your code coverage is less than 80%, could you improve it according to [quality-standards](https://github.com/avelino/awesome-go/blob/main/CONTRIBUTING.md#quality-standards)?

最早的时候性能比 mutex 是要更好一点的,可能随着 go 版本的迭代 mutex 锁的性能也改善了,需要多做点测试验证看看。

现在已经有了:https://pkg.go.dev/github.com/panjf2000/ants/v2#Pool.ReleaseTimeout