ants icon indicating copy to clipboard operation
ants copied to clipboard

Submitting task supports passing in arguments

Open hanfezh opened this issue 2 years ago β€’ 3 comments


name: Pull request about: Support passing in arguments to sumit task title: '' labels: '' assignees: ''

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

New feature.

2. Please describe how these code changes achieve your intention.

Support dynamic parameters when submitting task.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

  • [x] I have squashed all insignificant commits.
  • [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • [x] I have written unit tests and verified that all tests passes (if needed).
  • [x] I have documented feature info on the README (only when this PR is adding a new feature).
  • [x] (optional) I am willing to help maintain this change if there are issues with it later.

hanfezh avatar Jun 29 '22 14:06 hanfezh

Why do we need this?

Moreover, using any makes ants incompatible with the go versions before 1.18.

panjf2000 avatar Jun 30 '22 12:06 panjf2000

Why do we need this?

Moreover, using any makes ants incompatible with the go versions before 1.18.

It's more convenient and flexible than PoolWithFunc. And replace any with interface{}.

hanfezh avatar Jun 30 '22 12:06 hanfezh

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (32664cb) 92.46% compared to head (fa93833) 92.25%. Report is 62 commits behind head on master.

Files Patch % Lines
ants.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   92.46%   92.25%   -0.22%     
==========================================
  Files           9        9              
  Lines         717      723       +6     
==========================================
+ Hits          663      667       +4     
- Misses         41       43       +2     
  Partials       13       13              
Flag Coverage Ξ”
unittests 92.25% <77.77%> (-0.22%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 01 '22 13:07 codecov[bot]