ants
ants copied to clipboard
panjf2000
Submit a task with args to pool
name: Resolve problem with args capturing
1. Are you opening this pull request for bug-fixs, optimizations or new feature?
New feature.
2. Please describe how these code changes achieve your intention.
Sometimes, we need to call go-routines with args, but by default we have problem - wrong args capturing. And pool has the same problem. This PR resolves this problem.
3. Please link to the relevant issues (if any).
4. Which documentation changes (if any) need to be made/updated because of this PR?
4. Checklist
- [x] I have squashed all insignificant commits.
- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.
- [x] I have written unit tests and verified that all tests passes (if needed).
- [x] I have documented feature info on the README (only when this PR is adding a new feature).
- [ ] (optional) I am willing to help maintain this change if there are issues with it later.
Why bother when we already have https://github.com/panjf2000/ants/blob/master/pool_func.go?
It's not the same, for example, i need to have one pool for service without redefining. And sometimes I need to submit task with arguments, which will be captured without this functional. Now, I use an own solution for this. Your functional offers to create a new pool (for one time?).
Sorry, I don't get your point here, would you give me one case where the current API doesn't work and yours does?