twinstar icon indicating copy to clipboard operation
twinstar copied to clipboard

Splitting out `types` into libgemini?

Open aThorp96 opened this issue 3 years ago • 5 comments

Hello! I've been writing a small gemini client and I believe a lot of the functionality in the types directory could be used as a standalone library. Is that something that would be of interest at all?

aThorp96 avatar Jul 31 '21 16:07 aThorp96

I haven't actively worked on this library in a while, so right now I can not judge wether this is reasonable or even useful, but I am open to the idea.

panicbit avatar Jul 31 '21 16:07 panicbit

I've had a look now and decided to try splitting the module into a separate crate.

panicbit avatar Jul 31 '21 17:07 panicbit

I'm not sure wether to publish this as northstar-types or gemini-types though.

panicbit avatar Jul 31 '21 18:07 panicbit

This also raises the question of how to do versioning. If I'd keep the types crate in this repository, it would be the easiest to manage, but it would also make it unclear how to tag releases.

panicbit avatar Jul 31 '21 18:07 panicbit

One possibility would be to use features to either import the full package or just the gemini library. That would save some compile time on the end user's end without any operational overhead (I think) on the maintainers' end-- just the initial setup.

aThorp96 avatar Aug 08 '21 05:08 aThorp96