scikit-downscale icon indicating copy to clipboard operation
scikit-downscale copied to clipboard
verified publisher icon pangeo-data

Feature/add spatial disaggregation recipe

Open dgergel opened this issue 5 years ago • 4 comments

This PR adds the following:

  1. a full recipe for implementing the Thrasher et al. 2012 method for spatial disaggregation that is part of the Bias Correction and Spatial Disaggregation (BCSD) daily downscaling method
  2. structure for a new class of spatial models
  3. a fit/predict method for spatial disaggregation using the SpatialDisaggregator class in spatial models

dgergel avatar Jan 13 '21 18:01 dgergel

@dgergel - I just merged some changes in that should fix the CI for you. Go ahead and pull those in and then I'll take a look here.

jhamman avatar Jan 15 '21 04:01 jhamman

@jhamman sorry for the delay in fixing the pre-commit problems. This is finally ready for a review.

dgergel avatar Jan 29 '21 02:01 dgergel

Codecov Report

Merging #57 (098d8ea) into main (8a0c27e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 098d8ea differs from pull request most recent head 458f292. Consider uploading reports for the commit 458f292 to get more accurate results Impacted file tree graph

@@    Coverage Diff     @@
##   main   #57   +/-   ##
==========================
==========================

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a0c27e...458f292. Read the comment docs.

codecov[bot] avatar Apr 20 '21 03:04 codecov[bot]

@jhamman so sorry for taking so long to get back to this. I've made the changes you suggested and added unit tests, so this is ready for another review.

dgergel avatar Apr 20 '21 03:04 dgergel