pandora icon indicating copy to clipboard operation
pandora copied to clipboard

Feature request: Add multilanguage support for web interface

Open Foxi352 opened this issue 2 years ago • 12 comments

Are there any plans to support multiple languages for the web interface ?

Of course one could edit the template files (website/web/templates) manually. But this is not update proof and will block pull requests if same file has been updated remotely.

Foxi352 avatar Jul 06 '22 09:07 Foxi352

No, it is not planned yet. It might be something we will reconsider in late 2023, but it will require to extract all the text from the code and the templates and isn't worth the time at this point: the project will evolve a lot in the near future and supporting multiple languages will require to freeze all other development for a while.

If it is something you are interested in doing yourself, we can see how to collaborate so you can do it efficiently, or if you have funding for it.

Rafiot avatar Jul 06 '22 09:07 Rafiot

I fully get your point. I can only talk from personal past experience. If multi language is planned for somewhen, easiest IMHO is to implement the translation function and corresponding calls right from the beginning. Even if the only language delivered is english. Extracting all strings when the project has already grown, and replacing it by translation function calls will then get huge. And volunteer translators could start working on other languages and keep it in sync as the development progresses.

But i fully understand and respect your choice. I'll leave it up to you to keep this FR open as reminder or close it as you wish.

Foxi352 avatar Jul 06 '22 11:07 Foxi352

I'm not excluding it completely, but it wasn't a priority initially, and at this point it won't make much of a difference do do it now or later.

If a volunteer shows up, I'll happily assist.

Rafiot avatar Jul 06 '22 12:07 Rafiot

Hello @Foxi352 and @Rafiot

I am currently translating the web interface into german.I will make a request if I am finnished.

Regards,

Jay

JirR02 avatar Jul 06 '22 19:07 JirR02

cool! Are you making it modular? Or is it a straight translation you'll need to reapply the changes on every commit?

I'm happy to give a hand and make your life as easy as possible, if I can.

Rafiot avatar Jul 06 '22 20:07 Rafiot

I made a fork and used the latest commit. I am currently looking at the website code. and looking for bits which need translation. Is there any specification about the button to change the language? (Position, Color, looks, etc)

JirR02 avatar Jul 07 '22 06:07 JirR02

I think having a flag in the menubar at the top of the page will do fine (?) but if you have another idea, go for it.

Rafiot avatar Jul 07 '22 09:07 Rafiot

Hey guys.

Sorry for giving such a late update. I had to finnish up highschool and its been ruff the last two years so sorry for that. Also I live in Switzerland which I means I have to do the military. (and still doing it) So I was not able wo work that much on this project sadly. I experimented this weekend a bit with the code and was able to create a half working dropdown menu. The only thing that is not working is the fact that it does not hide. The Menu is just expanded. I am trying to find out what the problem is but any help would be appreciated.

            <ul class="navbar-nav mx-auto navbar-right">
              <li class="nav-item dropdown">
                <a class="nav-link dropdown-toggle" href="#" role="button">
                  English
                </a>
                <ul class"dropdown-menu">
                  <li><a class="dropdown-item" href="#">English</a></li>
                  <li><a class="dropdown-item" href="#">German</a></li>
                </ul>
              </li>
            </ul>

This is in the base.html file

JirR02 avatar Mar 31 '24 21:03 JirR02

No worries, we're not in a rush.

I'm not sure I understand what you mean, but when I have an issue with js/css stuff, the doc of bootstrap is pretty good, here for the dropdowns: https://getbootstrap.com/docs/5.3/components/dropdowns/

But if you do a PR, that would be easier.

Rafiot avatar Apr 02 '24 13:04 Rafiot

When I run my repository in the docker environment, the dropdown menu does not retract but stays expanded. Maybe it is something with my docker or I have overseen something in the code.

image

JirR02 avatar Apr 02 '24 20:04 JirR02

I haven't tested, but have you looked at the dev tools in your browser to see if there is an error? The rendering of the button isn't the bootstrap one, so I'm guessing the CSS isn't installed/loaded (?)

Rafiot avatar Apr 02 '24 21:04 Rafiot

I just realised. that there was a typo and I fixed it. I still get the same result with a different button so I am not really sure what the issue is. Should be visible in the PR.

JirR02 avatar Apr 27 '24 15:04 JirR02