asana icon indicating copy to clipboard operation
asana copied to clipboard

Additional parameters for get_project_tasks

Open p4r4noj4 opened this issue 10 years ago • 5 comments

Hey! I really like your AsanaAPI wrapper for Python, however I had performance issues, as I had to do manual checking for what's completed and had to get full information for each task one by one (which, as you can imagine, causes lots of network traffic). I found that the API allows to do some checking (completed/not completed) on the server side and that you can expand information by default. I made some simple changes so that those two things can be done through your awesome wrapper. I would be super-happy if you could integrate them to your project!

Cheers, Igor

p4r4noj4 avatar Mar 11 '14 11:03 p4r4noj4

Sorry it took me so long to get around this. I don't really use Asana anymore in my $DAYJOB. Should we perhaps default to include_completed=False ?

pandemicsyn avatar Apr 20 '14 07:04 pandemicsyn

Hey! I thought it would be good to have include_completed default to False, but at the same time I wanted everything to be consistent with how it worked before (that is - it worked as if include_completed was True), but I think we could change that anyway. Sorry for using wrong github user in commit (was trying to fix that, but git filter-branch was a little bit too much for me and I was afraid it would break something in your repository).

p4r4noj4 avatar Apr 22 '14 22:04 p4r4noj4

I have been using this api for a while, and was considering adding the ability to expand the data, on my own. Then i saw this pull request... Is this something that is going to get merged into the master branch? Thanks.

mudpuddle avatar Jul 24 '14 16:07 mudpuddle

With some new knowledge about git I actually managed to squish it all into one commit with right user. Merge please!

p4r4noj4 avatar Jul 29 '14 22:07 p4r4noj4

+1

Mte90 avatar Sep 24 '14 09:09 Mte90